migrate cronjob and hpa to new api versions #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pauvos we have fixed the pipelines! can you plz fetch the changes from upstream and update your PR? |
|
@pauvos can you plz update this? |
* Cronjob v1beta1 => v1 * HorizontalPodAutoscaler v2beta2 => v2 see https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25
pauvos
force-pushed
the
migrate-cronjob-hpa
branch
from
fe536f7 to
3ab00c3
Compare
|
@mustafaStakater validation successful` |
d3adb5
previously approved these changes
Mar 29, 2023
|
Looks good to me, but since I'm a new maintainer, I'd rather have another maintainer take a look and let me know if I missed something like a necessary addition to the CHANGELOG or something similar. |
application/templates/hpa.yaml
Outdated
| @@ -1,5 +1,9 @@ | |||
| {{- if and (.Values.autoscaling).enabled .Values.deployment }} | |||
| {{ if $.Capabilities.APIVersions.Has "autoscaling/v2/HorizontalPodAutoscaler" -}} | |||
There was a problem hiding this comment.
Why use $ when youre not within with or range
mustafaStakater
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25