Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Grafana Cloud #543

Merged
merged 13 commits into from
Oct 31, 2023
Merged

Add support for Grafana Cloud #543

merged 13 commits into from
Oct 31, 2023

Conversation

thunef
Copy link
Contributor

@thunef thunef commented Oct 30, 2023

@thunef thunef requested a review from MuneebAijaz October 30, 2023 10:42
@thunef thunef self-assigned this Oct 30, 2023
@github-actions
Copy link

github-actions bot commented Oct 30, 2023 •
edited
Loading

@thunef Image is available for testing. docker pull stakater/ingressmonitorcontroller:SNAPSHOT-PR-543-705923ad

@thunef thunef force-pushed the thunef/grafana-cloud branch 2 times, most recently from a914586 to dbdd975 Compare October 30, 2023 11:24
@thunef thunef mentioned this pull request Oct 30, 2023
Merged
@thunef thunef force-pushed the thunef/grafana-cloud branch from c872824 to 14cbedf Compare October 30, 2023 14:42
bnallapeta
bnallapeta reviewed Oct 31, 2023
View reviewed changes
Copy link

@bnallapeta bnallapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the minor comments.

@MuneebAijaz
Copy link
Contributor

i dont see changes from this version, https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.21.0/#for-golang-based-operators--change-makefile-targets-to-replace-go-get-with-go-install
can you pls go through the list again and check if you have done all the changes?

MuneebAijaz
MuneebAijaz requested changes Oct 31, 2023
View reviewed changes
api/v1alpha1/endpointmonitor_types.go Outdated Show resolved Hide resolved
pkg/monitors/appinsights/util.go Show resolved Hide resolved
pkg/monitors/grafana/grafana-monitor_test.go Show resolved Hide resolved
@thunef thunef force-pushed the thunef/grafana-cloud branch from 9143657 to 084fb30 Compare October 31, 2023 08:49
MuneebAijaz
MuneebAijaz requested changes Oct 31, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@thunef thunef force-pushed the thunef/grafana-cloud branch from 6334b29 to c9bde85 Compare October 31, 2023 09:24
@thunef thunef merged commit 93120d6 into master Oct 31, 2023
@thunef thunef deleted the thunef/grafana-cloud branch October 31, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnallapeta bnallapeta bnallapeta approved these changes

@MuneebAijaz MuneebAijaz MuneebAijaz approved these changes

Assignees

@thunef thunef

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thunef @MuneebAijaz @bnallapeta