Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added voice and banner instructions #2

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Conversation

Archdoog
Copy link
Collaborator

  • Adds VoiceInstruction
  • Adds BannerInstruction

@Archdoog Archdoog requested a review from ianthetechie April 18, 2024 01:23
Copy link
Contributor

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm getting down into the weeds now, but want to get in the habit of marking required fields as such. This will become important for dev ergonomics as we start using it.

Unfortunately I don't use OSRM directly and it's not very well-documented, but empirically you can refer to what's in Ferrostar, as it has test data from both Valhalla and the public OSRM demo instance.

For the mapbox extensions (like these), we rely on finding the right balance of Mapbox's publicly documented APIs and Valhalla. I think Mapbox always ships SSML for example, but Valhalla never does, so I leave that as optional.

openapi.yaml Show resolved Hide resolved
openapi.yaml Outdated Show resolved Hide resolved
openapi.yaml Outdated Show resolved Hide resolved
@ianthetechie ianthetechie merged commit 39ad70c into main Apr 18, 2024
1 check passed
@ianthetechie ianthetechie deleted the feat/voice-banner branch April 18, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants