Properly update sub model with type and modifier #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type and modifier fields are part of the official MapBox spec for allowed sub fields. In practice, they are mostly unused in favor of using them inside of components instead, but they are allowed and we are already parsing them, so this patch properly propagates them.
engali94
approved these changes
Dec 3, 2024
|
snippet from the documentation: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type and modifier fields are part of the official MapBox spec for allowed sub fields. In practice, they are mostly unused in favor of using them inside of components instead, but they are allowed and we are already parsing them, so this patch properly propagates them.