Fix state flow of mute UI updates on Android #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archdoog
reviewed
Nov 6, 2024
android/core/src/main/java/com/stadiamaps/ferrostar/core/NavigationViewModel.kt
Outdated
Show resolved
Hide resolved
…ationViewModel.kt Co-authored-by: Jacob Fielding <[email protected]>
Archdoog
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small bug fix. This one a bit more obvious.
In the present design, the UI state of the view model is exclusively from FerrostarCore's state. But the mute button being pressed is certainly a state update worth knowing about ;) This is less obvious of a problem when you're moving around, but very obvious when you're stationary / go inside, since the UI will appear to freeze until there's a navigation related update.