Add a skip.signing parameter for local publishing #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today, due to the signing requirement, one can no longer publish to Maven local for testing without having credentials. This patch adds an optional flag for disabling signing for cases when someone wants to publish locally for testing.
ahmedre
commented
Oct 22, 2024
| @@ -68,7 +68,9 @@ dependencies { | |||
|
|
|||
| mavenPublishing { | |||
| publishToMavenCentral(SonatypeHost.CENTRAL_PORTAL) | |||
There was a problem hiding this comment.
sorry to add more repetition here - at some point we should move this to a convention plugin and just apply it once so everyone gets it automatically.
There was a problem hiding this comment.
Yeah, makes sense... Maven local publishing has always been weird :/
ianthetechie
approved these changes
Oct 22, 2024
| @@ -68,7 +68,9 @@ dependencies { | |||
|
|
|||
| mavenPublishing { | |||
| publishToMavenCentral(SonatypeHost.CENTRAL_PORTAL) | |||
There was a problem hiding this comment.
Yeah, makes sense... Maven local publishing has always been weird :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, due to the signing requirement, one can no longer publish to Maven local for testing without having credentials. This patch adds an optional flag for disabling signing for cases when someone wants to publish locally for testing.