Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Gradle Secrets plugin #305

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

ianthetechie
Copy link
Contributor

I forgot to put this in the last PR... Halfway through integrating autocomplete search, I found a better way of doing this on Android which didn't require depending on yet another Gradle plugin.

@ianthetechie ianthetechie requested a review from Archdoog October 22, 2024 07:21
Copy link
Collaborator

@Archdoog Archdoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only note is, could we make this optional in this PR and default back to the demo tiles if not set?

I figure this is a good short PR to do that as well. (Happy to merge as is though first)

@ianthetechie
Copy link
Contributor Author

Ahh, good coll. Though at the moment, the search box can't work and we don't have simulated routes back yet.

@ianthetechie
Copy link
Contributor Author

App now works without an API key and doesn't crash ;)

image

@Archdoog
Copy link
Collaborator

Ah fair. In that case we can just create a ticket

@ianthetechie
Copy link
Contributor Author

Yeah, we know we need to to simulated routes anyways (without recompiling) in the wake of this anyways.

@ianthetechie ianthetechie merged commit 08898d5 into main Oct 22, 2024
14 checks passed
@ianthetechie ianthetechie deleted the remove-extraneous-secrets-plugin branch October 22, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants