[ios] InstructionView secondary row uses theme bg color #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while working on the InstructionView that the
secondaryStyle.backgroundColor
is ignored, and instead is hardcoded as a transformation of theprimaryStyle.backgroundColor
.I think using the
secondaryStyle.backgroundColor
is less surprising, so I've made that change.Further, while working on that, I noticed that all the render tests were using a test style (
TestingInstructionRowTheme
) rather than the default styles, which has a couple shortcomings:So, I've change these tests to use the default styles rather than the test style. However, I'm assuming there was a good reason for introducing the Test style in the first place, and so if it's still desirable for some reason, we can revisit that part of the change. For context, it looks like it was added as part of the original InstructionView feature in #71