Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nearest coordinate index for polyline #214

Merged
merged 18 commits into from
Sep 3, 2024
Merged

Added nearest coordinate index for polyline #214

merged 18 commits into from
Sep 3, 2024

Conversation

Archdoog
Copy link
Collaborator

  • Adds index of polyline coordinate calculator in preparation for current attributes and snap bearing/course.

@Archdoog Archdoog self-assigned this Aug 31, 2024
@ianthetechie ianthetechie self-requested a review September 1, 2024 00:15
ianthetechie
ianthetechie reviewed Sep 1, 2024
View reviewed changes
Copy link
Contributor

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran out of time this morning but here's a partial review.

common/ferrostar/src/navigation_controller/mod.rs Show resolved Hide resolved
common/ferrostar/src/navigation_controller/models.rs Outdated Show resolved Hide resolved
common/ferrostar/src/algorithms.rs Outdated Show resolved Hide resolved
common/ferrostar/src/algorithms.rs Outdated Show resolved Hide resolved
common/ferrostar/src/algorithms.rs Outdated Show resolved Hide resolved
common/ferrostar/src/algorithms.rs Outdated Show resolved Hide resolved
common/ferrostar/src/navigation_controller/mod.rs Outdated Show resolved Hide resolved
common/ferrostar/src/algorithms.rs Outdated Show resolved Hide resolved
common/ferrostar/src/algorithms.rs Outdated Show resolved Hide resolved
@ianthetechie
Copy link
Contributor

Discussed on Slack and decided to go with checks over the current route step for now, with the current index localized to the step. We will currently allow "backward" progress within a step, but we can always revisit this decision (ex: if it gets too jittery around boundaries).

@ianthetechie ianthetechie merged commit ceefeea into main Sep 3, 2024
14 checks passed
@ianthetechie ianthetechie deleted the feat/common/polyline-index branch September 3, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianthetechie ianthetechie ianthetechie left review comments

Assignees

@Archdoog Archdoog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archdoog @ianthetechie