Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish web SDK #189
Publish web SDK #189
Changes from 1 commit
e569f22
9708291
e0d4273
0201fed
187541b
2868fa6
b172d8c
9aa4472
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
config
object is required forcore.startNavigation
, but I'm not sure how to document it correctly. Also, should we include this as a default value forcore.startNavigation
in our web component code?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we made a change very recently which moves the config requirement to the
FerrostarCore
constructor on other platforms (Android example). I think doing the same on the web would be reasonable too. Most of the time you want to just set a config once. This makes it an optional override when callingstartNavigation
.Yeah, the above addresses this, but it should be an optional override with a default set on the
FerrostarCore
component. Somewhat related: thestartNavigationFromSearch
internal function currently just uses hard-coded values; storing the config at the component level can fix this.Re: documentation, I think it's good enough for now as the most common path is clear. We can improve customization docs as we refine the design.