Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent auto lock screen while navigating on iOS #163

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

CatMe0w
Copy link
Collaborator

@CatMe0w CatMe0w commented Jul 23, 2024

We certainly wouldn't want the phone to automatically lock the screen during navigation.

But I'm not so sure this should be added directly to the core, instead of the demo app. However, core itself comes with such behavior that may be unexpected, so I'll just add this to the demo app, leaving the choice to downstream developers and users.

Copy link
Contributor

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great; thanks! And I agree this is something that we should leave to app developers, not put in the core.

Can you also add a short paragraph (doesn't even need to be a full example; just reference + link to the Apple API docs) in the User Guide (iOS Tutorial chapter probably)? Just edit the markdown files under the guide folder; it's an mdbook project.

@ianthetechie ianthetechie merged commit ba1e65f into stadiamaps:main Jul 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants