Add arrival-view and instruction-view for web
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ian Wagner <[email protected]>
Co-authored-by: Ian Wagner <[email protected]>
ianthetechie
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is another big PR - I broke my local git branches somehow and eventually everything went into one single PR again.
A quick view
Other minor changes
Removed unused functions in
ferrostar-coreThese functions were originally placed with reference to the Android implementation, however Android is very different from the web (Lit), where the ModelView is very small, so there is no need to accurately copy all the internal details of the Android implementation.
Added a Stop Navigation button
However, not quite sure if this button should be moved inside
ferrostar-corecomponent, similar to the style implemented in Android.Known issues + TODOs
arrival-viewandinstruction-view