Feat/ios/dynamic navigation view #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apple/Sources/FerrostarMapLibreUI/Extensions/MapViewCamera.swift
Outdated
Show resolved
Hide resolved
apple/Sources/FerrostarMapLibreUI/Views/LandscapeNavigationView.swift
Outdated
Show resolved
Hide resolved
apple/Sources/FerrostarMapLibreUI/Views/LandscapeNavigationView.swift
Outdated
Show resolved
Hide resolved
apple/Sources/FerrostarMapLibreUI/Views/LandscapeNavigationView.swift
Outdated
Show resolved
Hide resolved
apple/Sources/FerrostarMapLibreUI/Views/DynamicallyOrientingNavigationView.swift
Outdated
Show resolved
Hide resolved
|
I checked the failed snapshot test diff & it was just a bit of the text rendering/alias on the speed limit sign. Probably need to add a percentage diff allowance here, but we can deal with that later. |
ianthetechie
approved these changes
Jul 27, 2024
Comment on lines
+22
to
+25
| public var topCenter: (() -> AnyView)? | ||
| public var topTrailing: (() -> AnyView)? | ||
| public var midLeading: (() -> AnyView)? | ||
| public var bottomTrailing: (() -> AnyView)? |
There was a problem hiding this comment.
Do we need to add these to the constructor? Or I guess there's an extension so maybe the idea is that you don't need to override(?) these very often so it's easier to just leave it to extension methods?
There was a problem hiding this comment.
Nope. To keep the constructors sane, I think these only get modified exclusively through the extension view modifier style.
Comment on lines
+20
to
+23
| public var topCenter: (() -> AnyView)? | ||
| public var topTrailing: (() -> AnyView)? | ||
| public var midLeading: (() -> AnyView)? | ||
| public var bottomTrailing: (() -> AnyView)? |
There was a problem hiding this comment.
Same question as above; different class ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39 (not directly, but I think it safely wraps up the discussion)