Upgrades to improved MapLibre Compose #156
Conversation
There was a problem hiding this comment.
When testing this, I ran into some issues. An API 35 emulator crashed instantly (ok it's dev; whatever...). An API 34 emulator is also segfaulting. It's crashing in a GL thread, which suggests it's related to MapLibre (not 100% sure but seems likely here).
2024-07-16 16:27:14.329 9192-9267 libc com.stadiamaps.ferrostar.demo A Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x30 in tid 9267 (GLThread 71), pid 9192 (.ferrostar.demo)
At first I thought it was related to the padding but I'm not sure now.
Is this working for you? If so, can you give more config details? Here's my AVD config:
| fun CameraPadding.Companion.NavigationPortrait(): CameraPadding { | ||
| return CameraPadding( | ||
| start = 0.0, | ||
| top = 1300.0, |
There was a problem hiding this comment.
I don't think this will work. At the very least it doesn't generalize to other screen sizes.
There was a problem hiding this comment.
This is gone and replaced by a much improved dynamic @composable.
| * A camera padding configuration for a navigation map view that places the user puck in the lower | ||
| * center of the screen. | ||
| */ | ||
| fun CameraPadding.Companion.NavigationPortrait(): CameraPadding { |
There was a problem hiding this comment.
General Android lint I noticed... I know what you're going for here though ;) Not sure if it's the right way or not TBH. I won't block the PR for this but something to think about.
There was a problem hiding this comment.
Yep. I've been ignoring those to keep it "kotlin enum like". I could put an actual suppression on it to note it's an intentional decision.
This branch has maplibre-compose 0.0.13, which reverts to maplibre 10. Testing proves the crash is not there. |
org.maplibre.android