Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking out from navigation camera on iOS #111

Conversation

Max-Leopold
Copy link
Contributor

Two small changes to fix breaking out from the navigation camera on iOS:

  1. Use a binding for the snapped instead of a constant to allow user to break from navigation camera.

It could be that this was done intentional to not allow breaking out from the navigation at all when using the DemoNavigationView. If so, feel free to ignore. The behavior looks quite buggy right now though because even if the user tries to move the map during navigation it will try to snap back to the user location.

  1. Drag gesture velocity can be negative. So we should check the absolute value of the gesture velocity against the breakwayVelocity.

@ianthetechie
Copy link
Contributor

Hey @Max-Leopold; sorry it's taken a bit to get to this. Just getting back from some travel.

It could be that this was done intentional to not allow breaking out from the navigation at all when using the DemoNavigationView. If so, feel free to ignore. The behavior looks quite buggy right now though because even if the user tries to move the map during navigation it will try to snap back to the user location.

Haha yeah, this was just a first hackish pass for a demo app. I'll try it out and give feedback but I'm guessing this is fine.

Drag gesture velocity can be negative. So we should check the absolute value of the gesture velocity against the breakwayVelocity.

heh ;) good catch.

Unrelated: the CI error isn't your fault. There's a fix pending merge in another branch. I'll take care of that.

@ianthetechie ianthetechie merged commit bd5272e into stadiamaps:main Jun 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants