Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nipun/ssv flag different validator dir #223

Conversation

fighting-dreamer
Copy link

@fighting-dreamer fighting-dreamer commented Oct 21, 2024

Aim of the PR :

  1. we are suppose to use "presign" dir in place of "validators"
  2. wallet users validators dir, it should use the presign directory.

broadly, in this PR, I have changes the host directory to be "presign" directory and mounted for the "validators" path.
the rest of logic remain as it it.

changes :

  1. update the flow that created these stader node related directory : install.sh
  2. update the templates to add mounting for validators path

@fighting-dreamer fighting-dreamer changed the base branch from main to nipun/add-reload-false-for-vc-deposit October 21, 2024 06:40
@fighting-dreamer fighting-dreamer marked this pull request as ready for review October 21, 2024 06:51
@batphonghan
Copy link
Contributor

I don’t think we should change the logic of the validator keys directory, as it's easy to cause errors. The changes should only introduce the presign directory.

@fighting-dreamer
Copy link
Author

I don’t think we should change the logic of the validator keys directory, as it's easy to cause errors. The changes should only introduce the presign directory.

@batphonghan can you share a scenario that might error out ?

@fighting-dreamer fighting-dreamer force-pushed the nipun/add-reload-false-for-vc-deposit branch from 225ae3c to 7ea9bba Compare October 22, 2024 11:47
@fighting-dreamer fighting-dreamer force-pushed the nipun/ssv-flag-different-validator-dir branch from 163416c to e31a46e Compare October 22, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants