Clarity Wasm #4756
Draft
Clarity Wasm #4756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-wasm-to-clarity
Previously, we used 4 bytes, but only 1 byte is necessary.
…erged-1214 Merged in latest next
This was fixed in #3945, but somehow got overwritten in this branch.
Annoyingly, we need to do this everytime we modify this repo until we come up with a better way to satisfy these interdependencies between clar2wasm and stacks-core.
This field is removed when not in `developer-mode`. This changeset ensures that the clarity module can build correctly when `developer-mode` is not enabled. See #3945
Something went wrong with the merges of changes from PR #3955 into `next` and this issue re-surfaced.
update linker functions
Update feat/clarity-wasm-develop branch
Instantiating a `wasmtime::Engine` is an expensive operation, so it is best to do it only once for the duration of a `GlobalContext`. Cloning an engine is, however, not an expensive operation (just an `Arc::clone`) and we use it to avoid referring to the global context already referred to by the instantiated `ClarityWasmContext`. See-also: stacks-network/clarity-wasm#468
feat(wasm): use only one `Engine` per global context
update clar2wasm dependency
…ons_to_trait add missing functions to trait
Merge develop onto clarity wasm
…(burn)-block-info-linker-fn Split `get-(burn)-block-info` linker function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the changes used for clarity-wasm. It may not yet be ready to be merged, but the clarity-wasm team is reviewing it as we go and then it will need a thorough review once it is ready to be merged into next.
This branch supersedes #3880, #4093, and the previous branch that was used by clarinet. The clarinet specific changes (to make the clarity crate compilable to wasm) are the starting point for the clarity-wasm changes.