Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-merge dependabot PRs when all checks pass #5147

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Mar 8, 2023

Description

Currently @dependabot PRs are handled by @stackrox/ui-dep-updaters and @stackrox/backend-dep-updaters this is fine but many times updates are small and could be automatically merged.
This PR adds automation that will approve and post @dependabot squash and merge comment. PR will be merged if all checks pass (not only required ones).

Example: mdn/content#25142 (review)

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Tested it on kube-linter

@janisz janisz requested review from a team March 8, 2023 10:45
@janisz janisz force-pushed the auto-merge-dependabot branch from f06c110 to 9f27879 Compare March 8, 2023 10:46
@ghost
Copy link

ghost commented Mar 8, 2023

Images are ready for the commit at c036b81.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.74.x-308-gc036b81a16.

@janisz janisz marked this pull request as draft March 8, 2023 16:56
@janisz janisz requested a review from vjwilson March 8, 2023 17:09
Copy link
Contributor

@vjwilson vjwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we can exclude front-end dependencies, then we can't turn auto-merge on.

@janisz janisz requested a review from vjwilson March 8, 2023 17:22
@janisz
Copy link
Contributor Author

janisz commented Mar 8, 2023

@vjwilson How about making it opt-in. If dependebot is configured to add auto-merge label then merge it automatically?

@janisz janisz marked this pull request as ready for review March 9, 2023 11:04
@janisz janisz merged commit f8520fe into master Mar 9, 2023
@janisz janisz deleted the auto-merge-dependabot branch March 9, 2023 11:05
@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2023

@janisz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-postgres-qa-e2e-tests c036b81 link false /test gke-postgres-qa-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants