Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update from CentOS Stream 8 to UBI 8 #205

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/actions/build-and-push-image/build-and-push-image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ build_and_push_image() {
# Login may be required for pulling the base image for building (if used) and to avoid rate limits.
docker login -u "$QUAY_RHACS_ENG_RW_USERNAME" --password-stdin <<<"$QUAY_RHACS_ENG_RW_PASSWORD" quay.io

STACKROX_CENTOS_TAG="$(cat STACKROX_CENTOS_TAG)"
TAG="$(scripts/get_tag.sh "$image_flavor" "${STACKROX_CENTOS_TAG}")"
TAG="$(scripts/get_tag.sh "$image_flavor")"
IMAGE="quay.io/rhacs-eng/apollo-ci:${TAG}"

make "$image_flavor"-image
Expand Down
4 changes: 0 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
ifeq ($(STACKROX_CENTOS_TAG),)
STACKROX_CENTOS_TAG=$(shell cat STACKROX_CENTOS_TAG)
endif
ifeq ($(DOCKER),)
DOCKER=docker
endif
Expand All @@ -12,7 +9,6 @@ STACKROX_BUILD_TAG=$(shell scripts/get_tag.sh "stackrox-build")
stackrox-build-image:
$(DOCKER) build \
-t quay.io/$(QUAY_REPO)/apollo-ci:$(STACKROX_BUILD_TAG) \
--build-arg STACKROX_CENTOS_TAG=$(STACKROX_CENTOS_TAG) \
-f images/stackrox-build.Dockerfile \
images/

Expand Down
1 change: 0 additions & 1 deletion STACKROX_CENTOS_TAG

This file was deleted.

2 changes: 1 addition & 1 deletion images/collector.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM quay.io/centos/centos:stream8
FROM registry.access.redhat.com/ubi8:latest

SHELL ["/bin/bash", "-o", "pipefail", "-c"]

Expand Down
2 changes: 1 addition & 1 deletion images/scanner-build.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Provides the tooling required to run Scanner dockerized build targets.

FROM quay.io/centos/centos:stream8
FROM registry.access.redhat.com/ubi8:latest

SHELL ["/bin/bash", "-o", "pipefail", "-c"]

Expand Down
34 changes: 27 additions & 7 deletions images/stackrox-build.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Provides the tooling required to run StackRox dockerized build targets.

ARG STACKROX_CENTOS_TAG
FROM quay.io/centos/centos:${STACKROX_CENTOS_TAG} as base
FROM registry.access.redhat.com/ubi8:latest

SHELL ["/bin/bash", "-o", "pipefail", "-c"]

Expand All @@ -10,24 +9,45 @@ RUN touch /i-am-rox-ci-image
RUN dnf update -y && \
dnf install -y \
dnf-plugins-core \
epel-release \
wget \
&& \
dnf config-manager --set-enabled powertools && \
dnf config-manager --set-enabled ubi-8-codeready-builder-rpms && \
dnf update -y && \
wget --quiet -O - https://rpm.nodesource.com/setup_lts.x | bash - && \
wget --quiet -O - https://dl.yarnpkg.com/rpm/yarn.repo | tee /etc/yum.repos.d/yarn.repo && \
dnf update -y && \
dnf -y groupinstall "Development Tools" && \
# This set replaces centos:stream8 "Development Tools". It is possible
# rox-ci-image does not need all of these.
dnf install -y \
autoconf \
automake \
binutils \
gcc \
gcc-c++ \
gdb \
glibc-devel \
libtool \
make \
pkgconf \
pkgconf-m4 \
pkgconf-pkg-config \
redhat-rpm-config \
rpm-build \
strace \
ctags \
git \
perl-Fedora-VSP \
perl-generators \
source-highlight && \
dnf install -y \
bzip2-devel \
gettext \
git-core \
jq \
libzstd-devel \
zstd \
lz4-devel \
nodejs \
procps-ng \
snappy-devel \
yarn \
zlib-devel \
&& \
Expand Down
3 changes: 0 additions & 3 deletions images/stackrox-test.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,11 @@ RUN dnf update -y && \
lsof \
lz4 \
openssl \
parallel \
python3-devel \
unzip \
xmlstarlet \
xz \
zip \
# `# Cypress dependencies: (see https://docs.cypress.io/guides/guides/continuous-integration.html#Dependencies)` \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a problem. I cannot find a UBI8 Xvfb.

xorg-x11-server-Xvfb gtk2-devel gtk3-devel libnotify-devel GConf2 nss libXScrnSaver alsa-lib \
&& \
dnf remove -y java-1.8.0-openjdk-headless && \
dnf --disablerepo="*" --enablerepo="pgdg14" install -y postgresql14 postgresql14-server postgresql14-contrib && \
Expand Down
2 changes: 1 addition & 1 deletion scripts/get_tag.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -euo pipefail

if [[ -z "${1:-}" ]]; then
echo "Usage: $0 <image flavor> [<centos_tag>]"
echo "Usage: $0 <image flavor>"
exit 1
fi

Expand Down
Loading