Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase alerting threshold for networt policy violations #265

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

mclasmeier
Copy link
Contributor

The alert is triggering to often currently.

This PR:

  • Removes one trigger entirely.
  • Increases the threshold for the second remaining trigger.

Here's a graph showing the amount of violations we currently have to treat as being normal:

image

@mclasmeier mclasmeier requested a review from a team as a code owner July 3, 2024 10:22
@stehessel
Copy link
Contributor

Wouldn't the spike up to 80 in the "normal" picture still trigger the alert?

Copy link

@GrimmiMeloni GrimmiMeloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@GrimmiMeloni
Copy link

Wouldn't the spike up to 80 in the "normal" picture still trigger the alert?

Yes, but those are to my understanding the ones we are actually interested in.
The "baseline noise" what is actually giving some trouble, as it causes just to many alerts to trigger.

@mclasmeier mclasmeier force-pushed the mc/increase-np-alerting-threshold branch from f24b331 to 5be4f02 Compare July 3, 2024 11:30
@mclasmeier mclasmeier force-pushed the mc/increase-np-alerting-threshold branch from 2723caa to 45f3e45 Compare July 4, 2024 06:57
@mclasmeier mclasmeier enabled auto-merge July 4, 2024 07:01
@mclasmeier mclasmeier disabled auto-merge July 4, 2024 07:01
@mclasmeier mclasmeier merged commit 164fa71 into master Jul 4, 2024
1 check passed
@mclasmeier mclasmeier deleted the mc/increase-np-alerting-threshold branch July 4, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants