Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24055: Annotations for cluster upgrades #240

Merged
merged 4 commits into from
May 7, 2024

Conversation

ludydoo
Copy link
Contributor

@ludydoo ludydoo commented May 6, 2024

No description provided.

@ludydoo ludydoo requested a review from a team as a code owner May 6, 2024 19:32
@ludydoo ludydoo requested a review from stehessel May 6, 2024 19:32
@stehessel
Copy link
Contributor

Could you please save a temporary copy of the updated dashboard and share the link? That makes reviewing much easier.

@ludydoo
Copy link
Contributor Author

ludydoo commented May 6, 2024

Could you please save a temporary copy of the updated dashboard and share the link? That makes reviewing much easier.

@stehessel sure, here it is:
https://grafana-route-rhacs-observability.apps.acs-int-us-01.isbr.p1.openshiftapps.com/d/ddkxpgdojslq8f/rhacs-dataplane-cluster-metrics-ludovic-copy?orgId=1

Though there's not enough retention time to go back to an upgrade where annotations would be visible

@ludydoo ludydoo requested a review from stehessel May 7, 2024 15:40
@stehessel
Copy link
Contributor

I guess it would be nice to see this in action. Have you actually tested it once and confirmed the rendering?

Another thought: The metric tracks changes to the underlying k8s version. Is this actually equivalent to the OCP upgrades? Couldn't there be OCP upgrades that don't change the k8s version?

@ludydoo ludydoo merged commit a02aca3 into master May 7, 2024
3 checks passed
@ludydoo ludydoo deleted the ROX-24055-upgrade-annotations branch May 7, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants