feat: add generic tenant metrics #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaus67
approved these changes
May 2, 2024
stehessel
force-pushed
the
feat/tenant-metrics
branch
from
f8679ca to
08383f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the central/scanner specific PodMonitors and replace with a generic PodMonitor that scrapes all ACS pods. This should then also include scannerV4 pods.
Note that since the external secrets operator was added, spinning up a local stack has become a bit more cumbersome. Therefore I didn't test this change locally, but since the change is straight forward I think it's probably fine to merge and test on integration.