-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graphs for cluster violations to Grafana dashboard #221
Conversation
mclasmeier
commented
Apr 22, 2024
•
edited
Loading
edited
Could you please save the dashboard under a new name (copy will be temporary) so it's easier to review the dashboard changes? |
Saved it additionally as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, could you add some information to the panel on what to do with this data? What is the expected / normal behavior? Do we expect there to always be zero violations, or are some violations acceptable? How could I get more information on what type of violations these are if I want to follow up?
Where should I add these information? From a quick search on the dashboards I haven't found panels including such a description @stehessel. |
@stehessel Feel free to re-review. Descriptions for the panels will be added in a follow-up commit as part of this PR. |
Dashboard updated (https://grafana-route-rhacs-observability.apps.acs-int-us-01.isbr.p1.openshiftapps.com/d/de195dda-1237-4285-af32-1fe0ad3d2ff1/57f53fcb-ad58-5fc3-8113-d8a7ec83161a?orgId=1), now includes descriptions. |
87df8d1
to
3c35c93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks 🚀 . For extra credit add a link to CloudWatch :).
3c35c93
to
0a8c135
Compare
Co-authored-by: Stephan Hesselmann <[email protected]>
Co-authored-by: Stephan Hesselmann <[email protected]>
Final changes -- board is updated: https://grafana-route-rhacs-observability.apps.acs-int-us-01.isbr.p1.openshiftapps.com/d/de195dda-1237-4285-af32-1fe0ad3d2ff1/57f53fcb-ad58-5fc3-8113-d8a7ec83161a?orgId=1&from=now-24h&to=now Changes:
|
@stehessel Given the approval, I will proceed with merging. Besides having included the cloudwatch links I also fixed a minor inconsistency by removing a bogus |