Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphs for cluster violations to Grafana dashboard #221

Merged
merged 10 commits into from
Apr 26, 2024

Conversation

mclasmeier
Copy link
Contributor

@mclasmeier mclasmeier commented Apr 22, 2024

image

@mclasmeier mclasmeier requested a review from a team as a code owner April 22, 2024 11:32
@mclasmeier mclasmeier requested a review from stehessel April 22, 2024 11:33
@stehessel
Copy link
Contributor

Could you please save the dashboard under a new name (copy will be temporary) so it's easier to review the dashboard changes?

@mclasmeier
Copy link
Contributor Author

Saved it additionally as RHACS Dataplane - Cluster Metrics (+ Cluster Violations).

Copy link
Contributor

@stehessel stehessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, could you add some information to the panel on what to do with this data? What is the expected / normal behavior? Do we expect there to always be zero violations, or are some violations acceptable? How could I get more information on what type of violations these are if I want to follow up?

resources/grafana/sources/rhacs-cluster-overview.json Outdated Show resolved Hide resolved
resources/grafana/sources/rhacs-cluster-overview.json Outdated Show resolved Hide resolved
resources/grafana/sources/rhacs-cluster-overview.json Outdated Show resolved Hide resolved
resources/grafana/sources/rhacs-cluster-overview.json Outdated Show resolved Hide resolved
@mclasmeier
Copy link
Contributor Author

mclasmeier commented Apr 24, 2024

In general, could you add some information to the panel on what to do with this data? What is the expected / normal behavior? Do we expect there to always be zero violations, or are some violations acceptable? How could I get more information on what type of violations these are if I want to follow up?

Where should I add these information? From a quick search on the dashboards I haven't found panels including such a description @stehessel.

@stehessel
Copy link
Contributor

You can either put a text box next to the plots like so

Screenshot 2024-04-24 at 15 10 33

or you can use the widget description. For longer text I would use the former.

For example, one might wonder how get to the component that generated the violation one sees on the dashboard. You can also just put a link to some other place where this info is available (e.g. a SOP or something like that).

@mclasmeier mclasmeier requested a review from stehessel April 24, 2024 13:18
@mclasmeier
Copy link
Contributor Author

@stehessel Feel free to re-review. Descriptions for the panels will be added in a follow-up commit as part of this PR.

@mclasmeier
Copy link
Contributor Author

@stehessel stehessel force-pushed the mc/violation-graphs branch from 87df8d1 to 3c35c93 Compare April 25, 2024 15:25
Copy link
Contributor

@stehessel stehessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 🚀 . For extra credit add a link to CloudWatch :).

@stehessel stehessel force-pushed the mc/violation-graphs branch from 3c35c93 to 0a8c135 Compare April 25, 2024 20:36
@mclasmeier
Copy link
Contributor Author

Final changes -- board is updated: https://grafana-route-rhacs-observability.apps.acs-int-us-01.isbr.p1.openshiftapps.com/d/de195dda-1237-4285-af32-1fe0ad3d2ff1/57f53fcb-ad58-5fc3-8113-d8a7ec83161a?orgId=1&from=now-24h&to=now

Changes:

  • Added CloudWatch Log Insight links
  • Removed a bogus "axisWidth" setting, which caused the y-axis (specifically its labels) to be mostly invisible for the first graph.

@mclasmeier
Copy link
Contributor Author

@stehessel Given the approval, I will proceed with merging. Besides having included the cloudwatch links I also fixed a minor inconsistency by removing a bogus axisWidth setting in one of the graphs. Thanks for the feedback!

@mclasmeier mclasmeier merged commit 4ec9919 into master Apr 26, 2024
1 check passed
@mclasmeier mclasmeier deleted the mc/violation-graphs branch April 26, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants