-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rhacs_expired_at
to centrals overview panel
#199
feat: add rhacs_expired_at
to centrals overview panel
#199
Conversation
Can you try to adjust the indentation of the source json such that the diff will hopefully be smaller? |
@stehessel, please look at the second commit of the PR. |
Why is that? |
I'm concerned that the next PR will once again change the indentation. Let's just add a prettier formatter then (in other PR). |
Btw for reviewing it can be nice to save the updated dashboard under a new name and share the link. The dashboard is not persisted and will be removed once the grafana pod is restarted. |
@stehessel , See #200. |
Please see the modified panel in "Test dashboards for PR review" → "PR 199" (DP production Grafana). |
3e7599e
to
355e820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks. One suggestion, I played with the test dashboard a bit and found that switching Minimum column width
from 200 -> auto renders the columns a bit nicer for me.
200 is the minimum width for "auto" resizing (they're two different settings). If I set less than 200, the "Expired At" column is cut for me. |
* ROX-21739: SES Monitoring * ROX-21739: PR Comments * Bump pre-commit/action from 3.0.0 to 3.0.1 (#198) Bumps [pre-commit/action](https://github.com/pre-commit/action) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/pre-commit/action/releases) - [Commits](pre-commit/action@v3.0.0...v3.0.1) --- updated-dependencies: - dependency-name: pre-commit/action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: prettier json (#200) * feat: add `rhacs_expired_at` to centrals overview panel (#199) * fix central overview table position (#202) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Ludovic Cleroux <[email protected]> Co-authored-by: Stephan Hesselmann <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michaël <[email protected]>
3 commits:
make generate
.