Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-21739: SES Monitoring #195

Merged
merged 2 commits into from
Feb 7, 2024
Merged

ROX-21739: SES Monitoring #195

merged 2 commits into from
Feb 7, 2024

Conversation

ludydoo
Copy link
Contributor

@ludydoo ludydoo commented Feb 7, 2024

Adding monitoring for AWS SES

@ludydoo ludydoo requested a review from a team as a code owner February 7, 2024 12:36
@ludydoo ludydoo requested a review from stehessel February 7, 2024 12:36
rules:
- alert: AWSSESReputationBounceRateTooHigh
expr: avg_over_time(aws_ses_reputation_bounce_rate_sum[1h]) > 0.05
for: 1s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for: 1s

Seems redundant when using avg_over_time(...[1h]). It'd either choose the average over time without for, or the plain metric aws_ses_reputation_bounce_rate_sum with a bigger for time.

severity: warning
annotations:
summary: 'AWS SES Send rate too high'
description: 'The SES send rate is {{ $value }} per second, which is dangerously approaching the maximum limit of 14 per second.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is a bit misleading because the value is the max over the last hour, but it reads like the current send rate value.

@ludydoo ludydoo requested a review from stehessel February 7, 2024 13:21
@ludydoo ludydoo merged commit 2dcb2e0 into master Feb 7, 2024
1 check passed
@ludydoo ludydoo deleted the ROX-21739-ses-monitoring branch February 7, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants