Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROX-21321: Add ACSCS release dashboard #184

Closed
wants to merge 1 commit into from
Closed

ROX-21321: Add ACSCS release dashboard #184

wants to merge 1 commit into from

Conversation

kurlov
Copy link
Member

@kurlov kurlov commented Dec 19, 2023

  • make generate locally also amended kube mixins files
  • Add dashboard which might be convenient during canary upgrade of ACSCS
Screenshot 2023-12-19 at 17 19 37

@kurlov kurlov requested a review from a team as a code owner December 19, 2023 16:21
@kurlov kurlov requested a review from stehessel December 19, 2023 16:21
@stehessel
Copy link
Contributor

make generate locally also amended kube mixins files

This doesn't happen for me or in CI. What versions of yq, jq and jsonnet are you using? I think we might need to pin them to avoid such inconsistencies.

@kurlov
Copy link
Member Author

kurlov commented Dec 19, 2023

I use:

  • yq 4.21.1
  • jq 1.6
  • jsonnet, jsonnet-deps v0.20.0

@stehessel
Copy link
Contributor

Can you try again with yq >= 4.40?

@kurlov kurlov mentioned this pull request Dec 20, 2023
Merged
@kurlov
Copy link
Member Author

kurlov commented Dec 20, 2023

@stehessel this should fix it #185

@kurlov kurlov closed this in #185 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stehessel stehessel Awaiting requested review from stehessel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurlov @stehessel