Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize overview dashboard queries #170

Closed
wants to merge 1 commit into from

Conversation

stehessel
Copy link
Contributor

@stehessel stehessel commented Nov 30, 2023

Optimize a few of the Grafana queries in the cluster overview dashboard:

  • Only show top 5/10 values dashboards that filter by namespace. This reduces the number of time series that are queried, and also makes the widgets less cluttered. Note that the actual number of different namespaces may still exceed 5/10 if the top namespaces changed during the dashboard time window.
  • Filter out useless data in the tenant table.
  • Enable pagination for the scanner table.
Screenshot 2023-11-30 at 16 03 26

@stehessel stehessel requested a review from a team as a code owner November 30, 2023 15:16
@stehessel stehessel force-pushed the optimize-overview-dashboard branch from 0c25ba4 to b7f9159 Compare December 1, 2023 02:43
Copy link
Contributor

@janisz janisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why indentation has changed?

@stehessel
Copy link
Contributor Author

stehessel commented Dec 1, 2023

There was a mix between tabs and spaces before. My guess is that somebody edited the .json by hand and used an editor which did that (probably me). Now it's just the .json generated by Grafana, which is all spaces. Or Grafana changed the tabs -> spaces, that might also be the case since we updated the Grafana version at some point.

@stehessel stehessel closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants