Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move tools to a separated module #816

Merged
merged 1 commit into from
Jul 24, 2024
Merged

chore: move tools to a separated module #816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/dependabot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,11 @@ updates:
k8s.io:
patterns:
- "k8s.io/*"
- package-ecosystem: 'gomod'
directory: 'tools-import'
schedule:
interval: 'weekly'
day: 'wednesday'
open-pull-requests-limit: 3
reviewers:
- "janisz"
8 changes: 6 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
.PHONY: deps
deps: go.mod go.sum
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a mistake we create a file here

deps: go.mod go.sum tool-imports/go.sum tool-imports/go.mod
@touch deps

%.sum: %.mod
@echo "+ $@"
@go mod tidy
ifdef CI
Expand Down Expand Up @@ -29,11 +31,13 @@ COVFILES := $(shell mktemp -d)
GOLANGCILINT_BIN := $(GOBIN)/golangci-lint
$(GOLANGCILINT_BIN): deps
@echo "+ $@"
cd tool-imports; \
GOBIN=$(GOBIN) go install github.com/golangci/golangci-lint/cmd/golangci-lint

GORELEASER_BIN := $(GOBIN)/goreleaser
$(GORELEASER_BIN): deps
@echo "+ $@"
cd tool-imports; \
GOBIN=$(GOBIN) go install github.com/goreleaser/goreleaser

###########
Expand Down
315 changes: 5 additions & 310 deletions go.mod
View file
Open in desktop

Large diffs are not rendered by default.

924 changes: 12 additions & 912 deletions go.sum
View file
Open in desktop

Large diffs are not rendered by default.

443 changes: 443 additions & 0 deletions tool-imports/go.mod
View file
Open in desktop

Large diffs are not rendered by default.

1,352 changes: 1,352 additions & 0 deletions tool-imports/go.sum
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion tool-imports/tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@ package toolimports
import (
_ "github.com/golangci/golangci-lint/cmd/golangci-lint"
_ "github.com/goreleaser/goreleaser"
_ "k8s.io/cli-runtime/pkg/resource" // This is imported because we want to be able to require it at a certain version, since otherwise Helm breaks.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see if we really need it

)
Loading