Fix: pdb-min-available when Replica number is controlled via HPA #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the pdb validation without hpa
janisz
reviewed
Jan 8, 2024
* feat: creates an HPA Map Object to avoid nested for * chore: rm unused code
* feat: creates an HPA Map Object to avoid nested for * chore: rm unused code * fix: map inicialization size * fix: bool check error
|
@janisz, giving an update: @jvtartaglia helped a lot in refining the code to avoid nested |
dineflansouza
approved these changes
Jan 10, 2024
janisz
reviewed
Jan 18, 2024
There was a problem hiding this comment.
LGTM except one last comment about supported versions.
Also if you like it will be great to have a e2e test for that with different autoscaling version .e.g: that will pass on this PR
---
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
name: baz
namespace: bar
spec:
minAvailable: 1
selector:
matchLabels:
name: example
---
apiVersion: autoscaling/v2beta1
kind: HorizontalPodAutoscaler
metadata:
name: app
namespace: bar
spec:
minReplicas: 4
maxReplicas: 100
scaleTargetRef:
apiVersion: apps/v1
kind: Deployment
name: foo
namespace: bar
targetCPUUtilizationPercentage: 85
---
apiVersion: apps/v1
kind: Deployment
metadata:
name: foo
namespace: bar
spec:
selector:
matchLabels:
name: example
template:
metadata:
labels:
name: example
…on-v2 version (#6) * feat: support to others autoscaling versions using extract package and an e2e-test with a non v2 version * Chore/reorganize code (#7) * chore: reorg code * chore: rename var --------- Co-authored-by: João Tartaglia <[email protected]>
janisz
approved these changes
Jan 23, 2024
|
@jpedrobf Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this solves #637.
The commit history might be a little messy but it was made with heart 💚