-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new check for liveness port #661
Create new check for liveness port #661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I've left some comments. I think we should use the same nomencalture as k8s so ports are exposed
not opened
. I think we should also support TCP
probes not only http
.
ec54b69
to
7df14b8
Compare
Thanks for the review! Have updated with the requested changes. |
@janisz, is there anything else you want me to change? Take another look when you have a chance. |
Want to ensure the port is correctly set for liveness probe since it's easy to make a typo when people are doing copy pasta. This will let you know it's failing airier and not have to wait for a failed deployment. Want to do this also for startup and readiness checks. Assume it make sense to have them as other checks and was planning on doing that in a follow up.
7df14b8
to
97b2cd9
Compare
@charlesoconor Thank you. I'm sorry I missed your comment, you can re-request review to speed up the process as I'll see this PR on my https://github.com/pulls board |
Want to ensure the port is correctly set for liveness probe since it's easy to make a typo when people are doing copy pasta. This will let you know it's failing airier and not have to wait for a failed deployment.
Want to do this also for startup and readiness checks. Assume it make sense to have them as other checks and was planning on doing that in a follow up.