Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefactor junit2jira #31

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Prefactor junit2jira #31

merged 1 commit into from
Nov 18, 2024

Conversation

mtodor
Copy link

@mtodor mtodor commented Nov 13, 2024

This PR is prefactoring for PR - #30.

Changes

  1. Go version is bumped to 1.21
  2. The project got an additional structure (cmd for commands, pkg for shared packages) - with that change almost everything from root directory has been moved to cmd/junit2jira
  3. Shared package contains handling of test cases.
  4. I decided to keep j2jTestCase struct instead of extending TestCase from the package in order to keep changes in junit2jira easier to review.
  5. Project is also renamed to: github.com/stackrox/junit2jira

@mtodor mtodor requested a review from porridge as a code owner November 13, 2024 09:48
@mtodor mtodor force-pushed the mtodor/add-flakechecker-prefactor branch from 70d36e1 to 35ee249 Compare November 13, 2024 09:49
porridge
porridge approved these changes Nov 14, 2024
View reviewed changes
Copy link

@porridge porridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one nitpick and one potential error found.

cmd/junit2jira/main.go Outdated Show resolved Hide resolved
cmd/junit2jira/main.go Outdated Show resolved Hide resolved
@mtodor mtodor force-pushed the mtodor/add-flakechecker-prefactor branch from 35ee249 to 541e548 Compare November 14, 2024 18:35
@mtodor mtodor merged commit fbc3ca5 into main Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janisz janisz janisz approved these changes

@porridge porridge porridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtodor @porridge @janisz