chore: upgrade Golang and Linter #1445
Conversation
|
A single node development cluster (infra-pr-1445) was allocated in production infra for this PR. CI will attempt to deploy 🔌 You can connect to this cluster with: 🛠️ And pull infractl from the deployed dev infra-server with: 🚲 You can then use the dev infra instance e.g.: Further Development☕ If you make changes, you can commit and push and CI will take care of updating the development cluster. 🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with: LogsLogs for the development infra depending on your @redhat.com authuser: Or: |
tommartensen
force-pushed
the
tm/upgrade-deps-2
branch
from
d0e6981 to
cb8505a
Compare
tommartensen
changed the title
| @@ -168,8 +168,6 @@ func (s *clusterImpl) List(ctx context.Context, request *v1.ClusterListRequest) | |||
| // Loop over all of the workflows, and keep only the ones that match our | |||
| // request criteria. | |||
| for _, workflow := range workflowList.Items { | |||
| workflow := workflow | |||
There was a problem hiding this comment.
were these flagged by the linting?
There was a problem hiding this comment.
Yes, detected by copyloopvar. This was a long standing issue in Go and resolved in 1.22.
See https://go.dev/blog/loopvar-preview.
A little present for the holidays. I also tried to bump dependencies, but it failed e2e tests - we should do them one by one in separate PRs (or use Dependabot).