Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: go1.22.5 #1382

Merged
merged 2 commits into from
Sep 12, 2024
Merged

chore: go1.22.5 #1382

merged 2 commits into from
Sep 12, 2024

Conversation

RTann
Copy link
Contributor

@RTann RTann commented Sep 10, 2024

No description provided.

@RTann RTann requested a review from BradLugo September 10, 2024 23:33
@RTann RTann requested a review from a team as a code owner September 10, 2024 23:33
@RTann
Copy link
Contributor Author

RTann commented Sep 10, 2024

@BradLugo I had to update the golang builder image and I also decided to update the go version used in the scripts/local-dev directory. Otherwise, nothing else changed after you reviewed

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Sep 10, 2024

A single node development cluster (infra-pr-1382) was allocated in production infra for this PR.

CI will attempt to deploy quay.io/rhacs-eng/infra-server:0.10.33-2-ga7ec8aef14 to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1382 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make install-local

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

@RTann
Copy link
Contributor Author

RTann commented Sep 11, 2024

@davdhacs @BradLugo I will need to create a new stackrox-test image because the current one is missing the parallel command, which is used by bats

@RTann
Copy link
Contributor Author

RTann commented Sep 11, 2024

Relies on stackrox/rox-ci-image#216 or #1385 to be merged prior to this

Copy link
Contributor

@davdhacs davdhacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RTann RTann merged commit f9414bd into master Sep 12, 2024
9 checks passed
@RTann RTann deleted the go1.22 branch September 12, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants