Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test go e2e before updates to grpc and gcloud storage #1378

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

davdhacs
Copy link
Contributor

@davdhacs davdhacs commented Sep 5, 2024

No description provided.

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Sep 5, 2024

A single node development cluster (infra-pr-1378) was allocated in production infra for this PR.

CI will attempt to deploy quay.io/rhacs-eng/infra-server:0.10.27-3-gde1b9cad62 to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1378 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make install-local

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

@davdhacs
Copy link
Contributor Author

davdhacs commented Sep 6, 2024

Tests passed after restoring before the updates to grpc and gcloud storage go deps. They then failed when re-applying the updates. Now testing if they pass again with removing the updates.

@davdhacs
Copy link
Contributor Author

davdhacs commented Sep 6, 2024

And the tests passed again ✅

@davdhacs davdhacs marked this pull request as ready for review September 6, 2024 21:44
@davdhacs davdhacs requested a review from a team as a code owner September 6, 2024 21:44
@davdhacs
Copy link
Contributor Author

davdhacs commented Sep 6, 2024

I will merge this to fix the go test by reverting the updates that I had approved from dependabot.

@davdhacs davdhacs merged commit 250852b into master Sep 6, 2024
9 checks passed
@davdhacs davdhacs deleted the fix-updates-for-gotests branch September 6, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants