update the Golang CI linter configuration

.golangci.yml

@@ -2,7 +2,9 @@ run:
   timeout: 16m
 
 output:
-  format: "junit-xml:report.xml,colored-line-number"
+  formats:
+    - format: junit-xml
+    - format: colored-line-number
 
 issues:
   exclude-use-default: false
@@ -35,8 +37,6 @@ linters-settings:
   gosec:
     includes:
       - G601
-  revive:
-    min-confidence: 0
   govet:
     enable-all: true
     disable:
@@ -56,16 +56,13 @@ linters-settings:
           - Warnf
           - Error
           - Errorf
-  gocritic:
-    enabled-checks:
-      - commentFormatting
   nolintlint:
-    allow-leading-space: false # require machine-readable nolint directives (i.e. with no leading space)
     allow-unused: false # report any unused nolint directives
     require-explanation: false # don't require an explanation for nolint directives
     require-specific: true # require nolint directives to be specific about which linter is being skipped
+  revive:
+    confidence: 0
   staticcheck:
-    go: "1.20"
     checks: [all, -ST1000, -ST1001, -ST1003, -ST1005, -SA1019, -SA4001, -ST1016]
   wrapcheck:
     ignoreSigRegexps:
@@ -81,6 +78,7 @@ linters:
   enable:
     - asciicheck
     # - bodyclose
+    - copyloopvar
     # - deadcode
     # - depguard
     # - dogsled
@@ -92,7 +90,6 @@ linters:
     # - gochecknoinits
     # - gocognit
     # - goconst
-    - exportloopref
     - gocritic
     # - gocyclo
     # - godot

service/cluster/cluster.go

@@ -168,8 +168,6 @@ func (s *clusterImpl) List(ctx context.Context, request *v1.ClusterListRequest)
 	// Loop over all of the workflows, and keep only the ones that match our
 	// request criteria.
 	for _, workflow := range workflowList.Items {
-		workflow := workflow
-
 		// This cluster is expired, and we did not request to include expired
 		// clusters.
 		if !request.Expired && isWorkflowExpired(workflow) {