Add rocksdb.patch to work with newer versions of gcc #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maddosaurus
approved these changes
May 10, 2022
| @@ -164,6 +164,9 @@ git clone https://github.com/facebook/rocksdb.git | |||
| cd rocksdb | |||
| git checkout v6.15.5 | |||
|
|
|||
| # Apply the RocksDB patch in this repo to support newer versions of gcc | |||
There was a problem hiding this comment.
Question: Should we have the patch in stackrox/stackrox as well?
We're setting a precedent for having the patch in this documentation repo.
I'm fine with this, but it also means you definitely need to have a look in this repo as well even if you only want to start working on stackrox/stackrox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.