Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-27485: Add comment not to delete source-location LABEL from Konflux Dockerfiles #2002

Merged

Conversation

tommartensen
Copy link
Contributor

Description

Context: https://issues.redhat.com/browse/ROX-27485 and stackrox/stackrox#13577

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • [ ] Added unit tests
  • [ ] Added integration tests
  • [ ] Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Konflux CI passing is sufficient.

@tommartensen tommartensen self-assigned this Jan 2, 2025
@tommartensen tommartensen requested a review from a team as a code owner January 2, 2025 14:42
@tommartensen tommartensen requested a review from a team January 2, 2025 14:57
@tommartensen
Copy link
Contributor Author

/test collector-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jan 2, 2025
Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An improvement suggestion, up to you.

collector/container/konflux.Dockerfile Outdated Show resolved Hide resolved
@tommartensen tommartensen merged commit 3eb2391 into master Jan 3, 2025
4 checks passed
@tommartensen tommartensen deleted the tm/ROX-27485-konflux-do-not-delete-source-location branch January 3, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants