-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-27384: Use the updated determine-image-tag
task
#2001
base: master
Are you sure you want to change the base?
ROX-27384: Use the updated determine-image-tag
task
#2001
Conversation
e5157ce
to
b480666
Compare
@msugakov: No presubmit jobs available for stackrox/collector@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5f39832
to
edd3b6c
Compare
so that it can be copied verbatim to release branches. I.e. there will be no diff in CEL expressions between `master` and `release-*` branches with such a CEL expression. Less diff -> simpler life when setting up release.
8d18e3b
to
30dbefa
Compare
/retest collector-on-push |
https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/pipelineruns/collector-on-push-5jbgt https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/pipelineruns/collector-on-push-f2plk https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/pipelineruns/collector-on-push-x4ng4 ``` Pipeline rh-acs-tenant/collector-on-push-x4ng4 can't be Run; it contains Tasks that don't exist: Couldn't retrieve Task "resolver type bundles\nname = push-dockerfile-oci-ta\n": error requesting remote resource: error getting "bundleresolver" "rh-acs-tenant/bundles-4f2dd5911b2fe10deb7f1183bbd278ea": cannot retrieve the oci image: GET https://quay.io/v2/konflux-ci/tekton-catalog/task-push-dockerfile-oci-ta/manifests/sha256:98ccae6ac132ab837fc51a70514be5fca656e09d6d4ad93230bd10f0119258aa: MANIFEST_UNKNOWN: manifest unknown; map[] ```
30dbefa
to
496df3b
Compare
because nothing else uses it in the repo and the `determine-image-tag` task has it inlined. This contributes to https://issues.redhat.com/browse/ROX-27488
/retest collector-on-push |
@msugakov: No presubmit jobs available for stackrox/collector@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one hint
/retest collector-on-push |
@msugakov: No presubmit jobs available for stackrox/collector@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest collector-on-push |
@msugakov: No presubmit jobs available for stackrox/collector@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest collector-on-push |
@msugakov: No presubmit jobs available for stackrox/collector@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ClamAV flake on Quay push in https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/pipelineruns/collector-on-push-smf87. All the rest is fine. Ignorable. |
Description
The task from stackrox/konflux-tasks#16 is used.
Checklist
[ ] Updated documentation accordinglyAutomated testing
No change.
Testing Performed
Validated with a few runs that tags come out as expected:
3.20.x-73-g496df3b530-fast
misha-test-8-fast
misha-test-8-0-g8d18e3b812-fast
misha-test-9-fast
misha-test-10-fast
misha-test-10-0-g4089d83c82-fast
Note that I cleaned up tags by the time of publishing this PR.