Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-27384: Use the updated determine-image-tag task #2001

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

msugakov
Copy link
Contributor

@msugakov msugakov commented Jan 2, 2025

Description

The task from stackrox/konflux-tasks#16 is used.

Checklist

  • Investigated and inspected CI test results
  • [ ] Updated documentation accordingly

Automated testing

No change.

Testing Performed

Validated with a few runs that tags come out as expected:

Note that I cleaned up tags by the time of publishing this PR.

@msugakov msugakov added backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 and removed do-not-merge/work-in-progress labels Jan 2, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Jan 2, 2025
@msugakov msugakov force-pushed the misha/ROX-27384-update-determine-tag-konflux-task branch from e5157ce to b480666 Compare January 7, 2025 13:47
Copy link

openshift-ci bot commented Jan 8, 2025

@msugakov: No presubmit jobs available for stackrox/collector@master

In response to this:

/retest collector-on-push

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@msugakov msugakov force-pushed the misha/ROX-27384-update-determine-tag-konflux-task branch 3 times, most recently from 5f39832 to edd3b6c Compare January 16, 2025 11:12
so that it can be copied verbatim to release branches. I.e. there
will be no diff in CEL expressions between `master` and `release-*`
branches with such a CEL expression.

Less diff -> simpler life when setting up release.
@msugakov
Copy link
Contributor Author

/retest collector-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Jan 16, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Jan 16, 2025
@msugakov msugakov force-pushed the misha/ROX-27384-update-determine-tag-konflux-task branch from 30dbefa to 496df3b Compare January 16, 2025 13:41
because nothing else uses it in the repo and the
`determine-image-tag` task has it inlined.
This contributes to https://issues.redhat.com/browse/ROX-27488
@msugakov msugakov marked this pull request as ready for review January 16, 2025 19:39
@msugakov msugakov requested a review from a team as a code owner January 16, 2025 19:39
@msugakov
Copy link
Contributor Author

/retest collector-on-push

Copy link

openshift-ci bot commented Jan 16, 2025

@msugakov: No presubmit jobs available for stackrox/collector@master

In response to this:

/retest collector-on-push

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@tommartensen tommartensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one hint

.tekton/collector-component-pipeline.yaml Show resolved Hide resolved
@msugakov
Copy link
Contributor Author

/retest collector-on-push

Copy link

openshift-ci bot commented Jan 20, 2025

@msugakov: No presubmit jobs available for stackrox/collector@master

In response to this:

/retest collector-on-push

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@msugakov
Copy link
Contributor Author

/retest collector-on-push

Copy link

openshift-ci bot commented Jan 20, 2025

@msugakov: No presubmit jobs available for stackrox/collector@master

In response to this:

/retest collector-on-push

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@msugakov
Copy link
Contributor Author

/retest collector-on-push

Copy link

openshift-ci bot commented Jan 20, 2025

@msugakov: No presubmit jobs available for stackrox/collector@master

In response to this:

/retest collector-on-push

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@msugakov
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants