Prevent overwriting test logs on multi VM tests #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running integration tests on multiple VMs with ansible, the logs generated may be overwritten as the different VMs end. This also causes the reports on the test summary to only show the result for the VMs that finish last. This situation is fine if all VMs have the same failures, but when only one of them is failing, (i.e: a verifier issue on a specific kernel) the error can get masked and incorrectly show all tests have passed. In order to fix this issue, logs and reports generated by CI should now have the VM name as part of their file name.
This reverts commit 6a1b81a.
Stringy
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running integration tests on multiple VMs with ansible, the logs
generated may be overwritten as the different VMs end. This also causes
the reports on the test summary to only show the result for the VMs that
finish last. This situation is fine if all VMs have the same failures,
but when only one of them is failing, (i.e: a verifier issue on a
specific kernel) the error can get masked and incorrectly show all tests
have passed.
In order to fix this issue, logs and reports generated by CI should now
have the VM name as part of their file name.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed