Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent pulling builder when building from source #1937

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Nov 4, 2024

Description

This is a workaround to a podman issue in which, adding --platform to a pull command, will cause podman to always pull the image. This is particularly annoying when testing changes to the builder image, since setting it to run will overwrite the local image and pull an existing one instead.

See #1922 for more context.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

  • Run multi-arch steps.

This is a workaround to a podman issue in which, adding --platform to a
pull command, will cause podman to always pull the image. This is
particularly annoying when testing changes to the builder image, since
setting it to run will overwrite the local image and pull an existing
one instead.
@Molter73 Molter73 added the run-multiarch-builds Run steps for non-x86 archs. label Nov 4, 2024
@Molter73 Molter73 requested a review from a team as a code owner November 4, 2024 11:40
@Molter73 Molter73 merged commit a9eebf2 into master Nov 5, 2024
55 of 79 checks passed
@Molter73 Molter73 deleted the mauro/prevent-unwanted-builder-pull branch November 5, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-multiarch-builds Run steps for non-x86 archs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants