Debug #1803
Draft
Debug #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erthalion
force-pushed
the
test/debug-release-3.19.2
branch
from
df79253 to
61089fe
Compare
Molter73
reviewed
Sep 30, 2024
AFAICT it's passed by reference in this PR, why would there be any copying involved? |
It's passed by reference to the constructors, but it is stored as a concrete value in these 2 places: So you'll get copies in the end, if you delete the implicit copy constructor for |
Pass CollectorConfig to the ProcessSignalHandler and ProcessSignalFormatter. It's needed for the future work, involving conditional logic in the process handler.
erthalion
force-pushed
the
test/debug-release-3.19.2
branch
2 times, most recently
from
35cbc8d to
a5b5ce3
Compare
erthalion
force-pushed
the
test/debug-release-3.19.2
branch
from
a5b5ce3 to
dff9081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A dummy PR to create a debugging version of 3.19.2