Clean up of perf results accesses and storage #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ovalenti
approved these changes
Oct 4, 2023
No, I think this bug has existed for a little while, though it might be affected by the change in names in the perf result ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes some boilerplate from the tests around the printing and storage of various perf results after the tests have executed. Now, perf results are all handled within the integration tests base struct, and the test simply has to call
WritePerfResultsinTearDownSuiteThis also fixes an issue where container stats weren't initialized properly, resulting in invalid perf reporting.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Tested locally against RHEL 8 and RHEL 9