Jv rox 21500 long running clusters should be able to run any commit #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| gh_log notice "working_directory= $working_directory" | ||
|
|
||
| ls | ||
| for file in `ls`; do |
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
Suggested change
| for file in `ls`; do | |
| for file in $(ls); do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft
Currently it is only possible to run the create long running github action for tagged commit that are short. E.g 4.3.0. Running with a longer tag such as 4.3.x-496-g61befc9f19 will cause the cluster name to be too long, resulting in a crash. This PR makes it possible run long running clusters with any commit.
Testing
Go to https://github.com/stackrox/test-gh-actions/actions/workflows/create-clusters.yml
Click "Run workflow"
Change the branch to jv-ROX-21500-long-running-clusters-should-be-able-to-run-any-commit
Change "Version of the images" to 4.3.x-496-g61befc9f19
Check "Create a long-running cluster on RC1"
Click "Run workflow"