Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove development environment log message #975

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

SimonBaeumer
Copy link
Member

Description

Remove development environment log message to make the CLI output clean.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary

Test manual

  • CI

@SimonBaeumer SimonBaeumer temporarily deployed to development April 21, 2023 09:10 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development April 21, 2023 09:10 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development April 21, 2023 09:10 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SimonBaeumer,johannes94]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SimonBaeumer SimonBaeumer merged commit 903eb05 into main Apr 24, 2023
@SimonBaeumer SimonBaeumer deleted the sb/remove-environment-log branch April 24, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants