Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve probe logging #965

Merged
merged 1 commit into from
Apr 19, 2023
Merged

improve probe logging #965

merged 1 commit into from
Apr 19, 2023

Conversation

stehessel
Copy link
Contributor

@stehessel stehessel commented Apr 18, 2023

Description

Small improvement of the probe logging:

  • Remove warnings emitted frequently while the probe is waiting for the instance to be ready/deleted. This warning creates a lot of spam in the logs.
  • Log target configuration when a probe run starts.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

@stehessel stehessel temporarily deployed to development April 18, 2023 20:07 — with GitHub Actions Inactive
@stehessel stehessel requested a review from a team April 18, 2023 20:07
@stehessel stehessel temporarily deployed to development April 18, 2023 20:07 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development April 18, 2023 20:07 — with GitHub Actions Inactive
@stehessel stehessel force-pushed the improve-probe-logging branch from f8fcf77 to e83b255 Compare April 18, 2023 20:09
@stehessel stehessel temporarily deployed to development April 18, 2023 20:09 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development April 18, 2023 20:09 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development April 18, 2023 20:09 — with GitHub Actions Inactive
Copy link

@dhaus67 dhaus67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, in the past when dealing with failing probe runs, the error messages for e.g. creation request failing where something along the lines of:

central creation failed: 403 forbidden

It would make initial triaging a lot faster when we could also print the error message within the logs contained within the http.Response we receive. OK for me to do this in a follow-up PR (I'm also open to change this if you don't feel like it right now since we are all relying on the probe service one way or another :) ).

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaus67, stehessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stehessel stehessel merged commit fe1e5d5 into main Apr 19, 2023
@stehessel stehessel deleted the improve-probe-logging branch April 19, 2023 08:42
@stehessel
Copy link
Contributor Author

I'm also open to change this if you don't feel like it right now since we are all relying on the probe service one way or another :)

I'd appreciate that, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants