Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode Fleet-Manager CLI command registration #963

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

SimonBaeumer
Copy link
Member

Description

Hardcoding the fleet-manager CLI command registration instead of using the DI container registration.
This removes the need of reflection and cleans up error logs dramatically.
The DI container is still passed to all commands.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

  • run CLI should work

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@SimonBaeumer SimonBaeumer temporarily deployed to development April 18, 2023 07:58 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development April 18, 2023 07:58 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development April 18, 2023 07:58 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer changed the title Hardcode Fleet-Manager CLI commands Hardcode Fleet-Manager CLI command registration Apr 18, 2023
@SimonBaeumer SimonBaeumer marked this pull request as ready for review April 18, 2023 08:00
@SimonBaeumer SimonBaeumer temporarily deployed to development April 18, 2023 08:00 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development April 18, 2023 08:00 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development April 18, 2023 08:00 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer requested a review from johannes94 April 18, 2023 08:03
Copy link
Member

@kurlov kurlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kurlov, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SimonBaeumer,kurlov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SimonBaeumer SimonBaeumer enabled auto-merge (squash) April 18, 2023 08:38
@SimonBaeumer SimonBaeumer merged commit 64c36b5 into main Apr 18, 2023
@SimonBaeumer SimonBaeumer deleted the sb/hardcode-command-registration branch April 18, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants