Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-13092: fix eventrouter rbac template #950

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

rhybrillou
Copy link
Contributor

Description

There was a typo in the RBAC part of the eventrouter templates. This PR fixes the fields.

Checklist (Definition of Done)

- [ ] Unit and integration tests added
- [ ] Added test description under Test manual
- [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)

  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
    - [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 13, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhybrillou rhybrillou requested a review from a team April 13, 2023 12:17
@rhybrillou rhybrillou force-pushed the yann/ROX-13092-fix_typo branch from 96049fc to 611e139 Compare April 13, 2023 12:45
@rhybrillou rhybrillou temporarily deployed to development April 13, 2023 12:46 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development April 13, 2023 12:46 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development April 13, 2023 12:46 — with GitHub Actions Inactive
@rhybrillou rhybrillou marked this pull request as ready for review April 13, 2023 12:50
@rhybrillou rhybrillou temporarily deployed to development April 13, 2023 12:50 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development April 13, 2023 12:50 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development April 13, 2023 12:50 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhybrillou, stehessel
Once this PR has been reviewed and has the lgtm label, please assign mtesseract for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhybrillou rhybrillou force-pushed the yann/ROX-13092-fix_typo branch from 611e139 to 8f9d4fe Compare April 13, 2023 13:49
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 13, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Apr 13, 2023
@rhybrillou rhybrillou temporarily deployed to development April 13, 2023 13:49 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development April 13, 2023 13:49 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development April 13, 2023 13:49 — with GitHub Actions Inactive
@rhybrillou rhybrillou merged commit e228ffe into main Apr 13, 2023
@rhybrillou rhybrillou deleted the yann/ROX-13092-fix_typo branch April 13, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants