Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install observability CRD via Helm #873

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

stehessel
Copy link
Contributor

Description

When provisioning a new data plane cluster by running the terraform chart for the first time, it fails with

Release "rhacs-terraform" does not exist. Installing it now.
Error: unable to build kubernetes objects from release manifest: resource mapping not found for name: "observability-stack" namespace: "rhacs-observability" from "": no matches for kind "Observability" in version "observability.redhat.com/v1"
ensure CRDs are installed first

By installing an initial version of the CRD via Helm, this problem should be fixed.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@stehessel stehessel temporarily deployed to development March 11, 2023 00:14 — with GitHub Actions Inactive
@stehessel stehessel requested a review from vladbologa March 13, 2023 11:34
@stehessel stehessel marked this pull request as ready for review March 13, 2023 23:57
@stehessel stehessel temporarily deployed to development March 13, 2023 23:57 — with GitHub Actions Inactive
@stehessel stehessel requested a review from a team March 14, 2023 10:19
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 0x656b694d, stehessel
Once this PR has been reviewed and has the lgtm label, please assign ivan-degtiarenko for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stehessel stehessel merged commit e449bbe into main Mar 16, 2023
@stehessel stehessel deleted the install-observability-crd branch March 16, 2023 13:55
johannes94 pushed a commit that referenced this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants