check that probe image exists before deployment #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: porridge, stehessel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
stehessel
force-pushed
the
check-probe-image-exists
branch
from
b3a77f3 to
b0cb003
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure that the probe image exists before we deploy, similar to what we already do for fleetshard-sync. This should address problems with deploying the probe service even though no new image has been built.
I refactored the image check script args and moved the script to the global scripts folder.
Checklist (Definition of Done)
Unit and integration tests addedAdded test description underTest manualDocumentation added if necessary (i.e. changes to dev setup, test execution, ...)Add the ticket number to the PR title if available, i.e.ROX-12345: ...Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.