ROX-15136: filter aws metrics by cluster name #857
Conversation
stehessel
temporarily deployed
to
development
GitHub Actions
Inactive
|
/retest |
1 similar comment
|
/retest |
| @@ -5,4 +5,4 @@ aws: | |||
|
|
|||
| clusterName: "" | |||
| environment: "" | |||
| image: "quay.io/prometheus/cloudwatch-exporter:v0.15.1" | |||
| image: "ghcr.io/nerdswords/yet-another-cloudwatch-exporter:v0.48.0-alpha" | |||
There was a problem hiding this comment.
because it has better filter and region support
To make it more concrete: It allows to pull metrics from multiple regions, it supports auto discovery of resources via tags (and it's written in Golang rather than Java 😅 ).
stehessel
force-pushed
the
ROX-15136/filter-by-cluster-name
branch
from
0a1d490 to
2228297
Compare
stehessel
force-pushed
the
ROX-15136/filter-by-cluster-name
branch
from
2228297 to
8ae0ee8
Compare
|
rebased to main to fix e2e test |
|
/retest |
| ports: | ||
| - name: monitoring | ||
| containerPort: 9106 |
There was a problem hiding this comment.
Is that port forwarded ? Does any service require adjustment here ?
There was a problem hiding this comment.
It's referenced by the pod monitor by the port name monitoring. So no other change should be necessary.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rhybrillou, stehessel The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This is a follow up to #846, which added cluster name tags to the Central RDS instances. Now we want to filter the exported metrics based on these cluster names in the cloudwatch exporter. This is done to allow us to only export metrics for RDS instances which belong to a specific ACS data plane region.
I decided to switch the exporter from https://github.com/prometheus/cloudwatch_exporter to https://github.com/nerdswords/yet-another-cloudwatch-exporter, because it has better filter and region support.
The metrics themselves are not changed by this, only the labels change slightly. Most notably, the dimension label will change from
dbinstance_identifiertodimension_DBInstanceIdentifier. We will have to change this in the alerts and dashboards.Checklist (Definition of Done)
Unit and integration tests addedTest manualDocumentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Test manual
Tested the exporter on dev cluster.